-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
I took the liberty of rebasing this and added /saveclothing and /loadclothing chat commands to make cross-shard clothing imports possible. |
I'm not so sure I like the idea of users being able to randomly change their clothing in the middle of a public age on any shard :/ |
You may be right, still I like the general idea. What do you suggest? Limiting it to the Personal age? |
As mentioned in IRC: how about we do a "modesty" type hack. External clients can only use these commands if they are the only player in the age. |
return | ||
file = file + ".clo" | ||
import os.path | ||
if os.path.exists(file): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In python we generally don't ask for permission. Maybe the C++ side should raise an exception (or return false) if the file supplied is not found, then we catch that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I could make the loading function return a boolean and evaluate it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Changing this will eliminate the feature of hiding the local avatar if the file does not exist. I will have a look at doing this manually in the startup python, then.
Updated. |
And here are the python functions for H-uru/Plasma#300