Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

Avatar clothing files #56

Merged
merged 2 commits into from
Dec 12, 2013
Merged

Avatar clothing files #56

merged 2 commits into from
Dec 12, 2013

Conversation

Mystler
Copy link
Contributor

@Mystler Mystler commented Feb 7, 2013

And here are the python functions for H-uru/Plasma#300

@Mystler
Copy link
Contributor Author

Mystler commented Dec 6, 2013

I took the liberty of rebasing this and added /saveclothing and /loadclothing chat commands to make cross-shard clothing imports possible.

@Hoikas
Copy link
Member

Hoikas commented Dec 6, 2013

I'm not so sure I like the idea of users being able to randomly change their clothing in the middle of a public age on any shard :/

@Mystler
Copy link
Contributor Author

Mystler commented Dec 6, 2013

You may be right, still I like the general idea. What do you suggest? Limiting it to the Personal age?

@Hoikas
Copy link
Member

Hoikas commented Dec 6, 2013

As mentioned in IRC: how about we do a "modesty" type hack. External clients can only use these commands if they are the only player in the age.

return
file = file + ".clo"
import os.path
if os.path.exists(file):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In python we generally don't ask for permission. Maybe the C++ side should raise an exception (or return false) if the file supplied is not found, then we catch that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I could make the loading function return a boolean and evaluate it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Changing this will eliminate the feature of hiding the local avatar if the file does not exist. I will have a look at doing this manually in the startup python, then.

@Mystler
Copy link
Contributor Author

Mystler commented Dec 9, 2013

Updated.

Hoikas added a commit that referenced this pull request Dec 12, 2013
@Hoikas Hoikas merged commit 4797d6d into H-uru:master Dec 12, 2013
@Mystler Mystler deleted the clothingfiles branch December 12, 2013 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants